Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheet): optimize memory release and resolve issues with the editor being recreated repeatedly #1432

Merged
merged 6 commits into from
Feb 29, 2024

Conversation

DR-Univer
Copy link
Collaborator

@DR-Univer DR-Univer commented Feb 28, 2024

  • I am sure that the code is update-to-date with the dev branch.

close #

Copy link

github-actions bot commented Feb 28, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 1.71674% with 229 lines in your changes are missing coverage. Please review.

Project coverage is 31.26%. Comparing base (c781f22) to head (57dc3ca).

Files Patch % Lines
packages/engine-render/src/scene.-transformer.ts 0.00% 88 Missing ⚠️
packages/sheets-ui/src/views/sheet-canvas-view.ts 0.00% 55 Missing ⚠️
.../docs-ui/src/controllers/page-render.controller.ts 0.00% 12 Missing ⚠️
...rc/controllers/editor/formula-editor.controller.ts 0.00% 9 Missing ⚠️
...-ui/src/services/sheet-skeleton-manager.service.ts 0.00% 8 Missing ⚠️
packages/ui/src/services/editor/editor.service.ts 0.00% 8 Missing ⚠️
.../docs/src/controllers/text-selection.controller.ts 0.00% 6 Missing ⚠️
.../docs/src/services/doc-skeleton-manager.service.ts 0.00% 5 Missing ⚠️
packages/engine-render/src/layer.ts 0.00% 5 Missing ⚠️
packages/engine-render/src/scene.ts 0.00% 5 Missing ⚠️
... and 12 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1432      +/-   ##
==========================================
- Coverage   31.30%   31.26%   -0.05%     
==========================================
  Files         876      876              
  Lines       49085    49144      +59     
  Branches    10132    10139       +7     
==========================================
- Hits        15366    15364       -2     
- Misses      33719    33780      +61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Codecov Report

Attention: Patch coverage is 1.33333% with 222 lines in your changes are missing coverage. Please review.

Project coverage is 31.27%. Comparing base (c781f22) to head (0a71dfb).

Files Patch % Lines
packages/engine-render/src/scene.-transformer.ts 0.00% 88 Missing ⚠️
packages/sheets-ui/src/views/sheet-canvas-view.ts 0.00% 55 Missing ⚠️
.../docs-ui/src/controllers/page-render.controller.ts 0.00% 12 Missing ⚠️
...rc/controllers/editor/formula-editor.controller.ts 0.00% 9 Missing ⚠️
...-ui/src/services/sheet-skeleton-manager.service.ts 10.00% 9 Missing ⚠️
packages/ui/src/services/editor/editor.service.ts 0.00% 9 Missing ⚠️
.../docs/src/controllers/text-selection.controller.ts 0.00% 6 Missing ⚠️
packages/engine-render/src/layer.ts 0.00% 5 Missing ⚠️
packages/engine-render/src/scene.ts 0.00% 5 Missing ⚠️
...s-ui/src/controllers/editor/end-edit.controller.ts 0.00% 5 Missing ⚠️
... and 10 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1432      +/-   ##
==========================================
- Coverage   31.30%   31.27%   -0.04%     
==========================================
  Files         876      876              
  Lines       49085    49143      +58     
  Branches    10132    10138       +6     
==========================================
+ Hits        15366    15368       +2     
- Misses      33719    33775      +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DR-Univer DR-Univer merged commit b14207b into dev Feb 29, 2024
7 checks passed
@DR-Univer DR-Univer deleted the fix-editor-service-dispose branch February 29, 2024 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants