Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): editor modifications to accommodate the range selector #1460

Merged
merged 15 commits into from
Mar 2, 2024

Conversation

DR-Univer
Copy link
Collaborator

@DR-Univer DR-Univer commented Mar 2, 2024

  • Read-Only

  • Multi-line and Single-line Configuration

  • Editor Style Aligned with DOM Input

  • Formula Input Validation Only

  • Range Input Validation Only

  • Error Message Display

  • I am sure that the code is update-to-date with the dev branch.

close #

Copy link

github-actions bot commented Mar 2, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@DR-Univer DR-Univer requested a review from Gggpound as a code owner March 2, 2024 11:31
Copy link

codecov bot commented Mar 2, 2024

Codecov Report

Attention: Patch coverage is 6.52174% with 172 lines in your changes are missing coverage. Please review.

Project coverage is 31.51%. Comparing base (d503dc5) to head (04c3c46).
Report is 2 commits behind head on dev.

Files Patch % Lines
packages/ui/src/services/editor/editor.service.ts 0.00% 65 Missing ⚠️
packages/ui/src/components/editor/TextEditor.tsx 0.00% 48 Missing ⚠️
...ui/src/controllers/doc-editor-bridge.controller.ts 0.00% 30 Missing ⚠️
...cs-ui/src/controllers/text-selection.controller.ts 0.00% 18 Missing ⚠️
packages/core/src/shared/debounce.ts 0.00% 8 Missing ⚠️
packages/docs-ui/src/shortcuts/utils.ts 0.00% 2 Missing ⚠️
...es/engine-formula/src/models/formula-data.model.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1460      +/-   ##
==========================================
- Coverage   31.59%   31.51%   -0.08%     
==========================================
  Files         879      880       +1     
  Lines       49221    49364     +143     
  Branches    10154    10188      +34     
==========================================
+ Hits        15553    15559       +6     
- Misses      33668    33805     +137     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Codecov Report

Attention: Patch coverage is 6.89655% with 162 lines in your changes are missing coverage. Please review.

Project coverage is 31.51%. Comparing base (d503dc5) to head (608000f).

Files Patch % Lines
packages/ui/src/services/editor/editor.service.ts 0.00% 68 Missing ⚠️
packages/ui/src/components/editor/TextEditor.tsx 0.00% 48 Missing ⚠️
...cs-ui/src/controllers/text-selection.controller.ts 0.00% 18 Missing ⚠️
...ui/src/controllers/doc-editor-bridge.controller.ts 0.00% 16 Missing ⚠️
packages/core/src/shared/debounce.ts 0.00% 8 Missing ⚠️
packages/docs-ui/src/shortcuts/utils.ts 0.00% 2 Missing ⚠️
...es/engine-formula/src/models/formula-data.model.ts 50.00% 1 Missing ⚠️
...kages/sheets-ui/src/views/status-bar/StatusBar.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1460      +/-   ##
==========================================
- Coverage   31.59%   31.51%   -0.08%     
==========================================
  Files         879      880       +1     
  Lines       49221    49363     +142     
  Branches    10154    10190      +36     
==========================================
+ Hits        15553    15559       +6     
- Misses      33668    33804     +136     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DR-Univer DR-Univer merged commit 22b2734 into dev Mar 2, 2024
7 checks passed
@DR-Univer DR-Univer deleted the feat-range-selector branch March 2, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants