Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(doc): need to serialize text ranges #1487

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Mar 5, 2024

  • I am sure that the code is update-to-date with the dev branch.

close #1476

@Jocs Jocs marked this pull request as ready for review March 5, 2024 10:33
@Jocs Jocs requested a review from DR-Univer as a code owner March 5, 2024 10:33
Copy link

github-actions bot commented Mar 5, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@Jocs Jocs added the qa:untested This PR is ready to be tested label Mar 5, 2024
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.59%. Comparing base (885ba4b) to head (8941857).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1487   +/-   ##
=======================================
  Coverage   32.59%   32.59%           
=======================================
  Files         905      905           
  Lines       50121    50121           
  Branches    10431    10431           
=======================================
  Hits        16335    16335           
  Misses      33786    33786           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaolixin7 zhaolixin7 added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Mar 5, 2024
@zhaolixin7
Copy link

todo: @zhaolixin7 复现场景:在协同时可以复现报错,dev无法协同待合到staging上验证

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


todo: @zhaolixin7 Reproduction scenario: the error can be reproduced during collaboration, but dev cannot collaborate and needs to be verified on staging

@Jocs Jocs merged commit de87e10 into dev Mar 5, 2024
7 checks passed
@Jocs Jocs deleted the fix/serilize-text-ranges branch March 5, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] 文档设置格式不生效,控制台报错
4 participants