Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(design): restore styles for non-draggable dialog #1498

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Conversation

jikkai
Copy link
Member

@jikkai jikkai commented Mar 6, 2024

  • I am sure that the code is update-to-date with the dev branch.

@jikkai jikkai requested a review from wzhudev as a code owner March 6, 2024 13:48
Copy link

github-actions bot commented Mar 6, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 32.66%. Comparing base (44ec056) to head (00e37f4).

Files Patch % Lines
packages/design/src/components/dialog/Dialog.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1498   +/-   ##
=======================================
  Coverage   32.66%   32.66%           
=======================================
  Files         908      908           
  Lines       50482    50482           
  Branches    10521    10521           
=======================================
  Hits        16491    16491           
  Misses      33991    33991           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jikkai jikkai merged commit ee694f2 into dev Mar 6, 2024
7 checks passed
@jikkai jikkai deleted the fix/dialog branch March 6, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant