Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(formula): support cubeValueObject #1536

Merged
merged 4 commits into from
Mar 10, 2024
Merged

Conversation

DR-Univer
Copy link
Collaborator

@DR-Univer DR-Univer commented Mar 9, 2024

  • Support has been added for the CubeValueObject, allowing the completion of some methods and the implementation of the INDEX function, but cubes do not permit numerical and comparative calculations.

close #

Copy link

github-actions bot commented Mar 9, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Mar 9, 2024

Codecov Report

Attention: Patch coverage is 27.84810% with 57 lines in your changes are missing coverage. Please review.

Project coverage is 32.92%. Comparing base (91397c6) to head (deed070).
Report is 1 commits behind head on dev.

Files Patch % Lines
...rmula/src/engine/value-object/cube-value-object.ts 0.00% 40 Missing ⚠️
...es/engine-formula/src/functions/meta/cube/index.ts 0.00% 12 Missing ⚠️
...-formula/src/engine/analysis/lexer-tree-builder.ts 86.95% 3 Missing ⚠️
...rmula/src/engine/value-object/base-value-object.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1536      +/-   ##
==========================================
+ Coverage   32.78%   32.92%   +0.14%     
==========================================
  Files         913      919       +6     
  Lines       50803    51081     +278     
  Branches    10592    10626      +34     
==========================================
+ Hits        16656    16820     +164     
- Misses      34147    34261     +114     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DR-Univer DR-Univer changed the title feat(formula): cube value object feat(formula): support cubeValueObject Mar 9, 2024
@DR-Univer DR-Univer merged commit 1c77658 into dev Mar 10, 2024
7 checks passed
@DR-Univer DR-Univer deleted the feat-support-cube-object branch March 10, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants