Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(design): fix title in Dialog to use passed variable #1556

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Conversation

jikkai
Copy link
Member

@jikkai jikkai commented Mar 12, 2024

  • I am sure that the code is update-to-date with the dev branch.

@jikkai jikkai requested a review from wzhudev as a code owner March 12, 2024 09:47
Copy link

github-actions bot commented Mar 12, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 32.86%. Comparing base (751b491) to head (883734c).
Report is 1 commits behind head on dev.

Files Patch % Lines
packages/design/src/components/dialog/Dialog.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1556   +/-   ##
=======================================
  Coverage   32.86%   32.86%           
=======================================
  Files         919      919           
  Lines       51200    51200           
  Branches    10661    10661           
=======================================
  Hits        16825    16825           
  Misses      34375    34375           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jikkai jikkai merged commit 5aeb65f into dev Mar 12, 2024
7 checks passed
@jikkai jikkai deleted the fix/dialog branch March 12, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant