Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheet): keep consistent with excel rotation #1562

Merged
merged 3 commits into from
Mar 14, 2024

Conversation

DR-Univer
Copy link
Collaborator

@DR-Univer DR-Univer commented Mar 12, 2024

  • I am sure that the code is update-to-date with the dev branch.

for https://github.com/dream-num/univer-pro/issues/334

close #

@DR-Univer DR-Univer requested a review from wzhudev as a code owner March 12, 2024 15:45
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Mar 12, 2024
Copy link

github-actions bot commented Mar 12, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 51 lines in your changes are missing coverage. Please review.

Project coverage is 32.84%. Comparing base (5aeb65f) to head (755d83c).
Report is 11 commits behind head on dev.

Files Patch % Lines
...ages/engine-render/src/components/docs/document.ts 0.00% 18 Missing ⚠️
...ine-render/src/components/sheets/sheet-skeleton.ts 0.00% 16 Missing ⚠️
...ne-render/src/components/sheets/extensions/font.ts 0.00% 13 Missing ⚠️
packages/engine-render/src/basics/text-rotation.ts 0.00% 2 Missing ⚠️
...ui/src/controllers/editor/start-edit.controller.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1562      +/-   ##
==========================================
- Coverage   32.86%   32.84%   -0.02%     
==========================================
  Files         919      919              
  Lines       51202    51222      +20     
  Branches    10661    10666       +5     
==========================================
  Hits        16825    16825              
- Misses      34377    34397      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DR-Univer DR-Univer requested a review from Jocs as a code owner March 13, 2024 09:35
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Mar 14, 2024
@univer-bot univer-bot bot removed qa:untested This PR is ready to be tested qa:verified This PR has already by verified by a QA and is considered good enough to be merge labels Mar 14, 2024
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Mar 14, 2024
@DR-Univer DR-Univer merged commit c100bc8 into dev Mar 14, 2024
7 checks passed
@DR-Univer DR-Univer deleted the fix-sheet-cell-rotation-align branch March 14, 2024 07:49
ybzky pushed a commit that referenced this pull request Mar 19, 2024
* fix(sheet): keep consistent with excel rotation

* refactor(sheet): rotation update

* fix(sheet): type error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants