Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): style and placeholder #1571

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Conversation

DR-Univer
Copy link
Collaborator

@DR-Univer DR-Univer commented Mar 13, 2024

  • editor style
  • selector style
  • placeholder
  • fix select range bug

close #

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Mar 13, 2024
@DR-Univer DR-Univer changed the title fix(editor): style feat(editor): style and placeholder Mar 13, 2024
Copy link

github-actions bot commented Mar 13, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 36 lines in your changes are missing coverage. Please review.

Project coverage is 32.81%. Comparing base (bba50e7) to head (13f0d07).
Report is 1 commits behind head on dev.

Files Patch % Lines
packages/ui/src/components/editor/TextEditor.tsx 0.00% 14 Missing ⚠️
...ui/src/components/range-selector/RangeSelector.tsx 0.00% 13 Missing ⚠️
packages/ui/src/services/editor/editor.service.ts 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1571      +/-   ##
==========================================
- Coverage   32.83%   32.81%   -0.02%     
==========================================
  Files         919      919              
  Lines       51237    51265      +28     
  Branches    10668    10680      +12     
==========================================
  Hits        16825    16825              
- Misses      34412    34440      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DR-Univer DR-Univer merged commit be4482c into dev Mar 14, 2024
7 checks passed
@DR-Univer DR-Univer deleted the feat-editor-selector-style branch March 14, 2024 03:05
@DR-Univer DR-Univer restored the feat-editor-selector-style branch March 14, 2024 03:05
@DR-Univer DR-Univer deleted the feat-editor-selector-style branch March 14, 2024 03:05
ybzky pushed a commit that referenced this pull request Mar 19, 2024
* fix(editor): style

* fix(editor): placeholder gray
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:untested This PR is ready to be tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant