Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(formula): math functions support string number calculation #1581

Merged
merged 4 commits into from
Mar 16, 2024
Merged

fix(formula): math functions support string number calculation #1581

merged 4 commits into from
Mar 16, 2024

Conversation

Dushusir
Copy link
Member

@Dushusir Dushusir commented Mar 14, 2024 •
edited
Loading

  • I am sure that the code is update-to-date with the dev branch.

close #1390
close #1269

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Mar 14, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 14, 2024 •
edited
Loading

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@codecov Codecov
Copy link

codecov bot commented Mar 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 78.78788% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 32.45%. Comparing base (86b442b) to head (5f5d170).
Report is 1 commits behind head on dev.

Files Patch % Lines
...rmula/src/engine/value-object/base-value-object.ts 40.00% 6 Missing ⚠️
...es/engine-formula/src/functions/math/acos/index.ts 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #1581      +/-   ##
==========================================
+ Coverage   32.38%   32.45%   +0.06%     
==========================================
  Files         923      924       +1     
  Lines       52159    52183      +24     
  Branches    10886    10893       +7     
==========================================
+ Hits        16890    16934      +44     
+ Misses      35269    35249      -20

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaolixin7 zhaolixin7 added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Mar 14, 2024
@Dushusir Dushusir added qa:untested This PR is ready to be tested and removed qa:verified This PR has already by verified by a QA and is considered good enough to be merge labels Mar 14, 2024
@Dushusir Dushusir marked this pull request as ready for review March 14, 2024 12:53
@Dushusir Dushusir force-pushed the dushusir/formula-cal branch 2 times, most recently from ff05c08 to 5dbc7e9 Compare March 15, 2024 11:09
@zhaolixin7 zhaolixin7 added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Mar 15, 2024
@Dushusir Dushusir merged commit 0779488 into dev Mar 16, 2024
7 checks passed
@Dushusir Dushusir deleted the dushusir/formula-cal branch March 16, 2024 04:03
ybzky pushed a commit that referenced this pull request Mar 19, 2024
@Dushusir
fix(formula): math functions support string number calculation (#1581)
fd87daf 
* fix(formula): math functions support string number calculation

* fix(formula): plus,minus,multiply,divided functions return value error

* fix(formula): use string to create StringValueObject

* fix(formula): use convertToNumberObjectValue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DR-Univer DR-Univer DR-Univer approved these changes

Assignees
No one assigned
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Milestone
No milestone
3 participants
@Dushusir @DR-Univer @zhaolixin7