Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(formula): dependency maintain #1638

Merged
merged 7 commits into from
Apr 18, 2024
Merged

perf(formula): dependency maintain #1638

merged 7 commits into from
Apr 18, 2024

Conversation

DR-Univer
Copy link
Collaborator

@DR-Univer DR-Univer commented Mar 19, 2024

  1. add dependency manager service

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 9.62963% with 244 lines in your changes are missing coverage. Please review.

Project coverage is 29.71%. Comparing base (5b6e223) to head (c614f85).
Report is 10 commits behind head on dev.

Files Patch % Lines
...formula/src/services/dependency-manager.service.ts 1.00% 99 Missing ⚠️
...ormula/src/engine/dependency/formula-dependency.ts 0.00% 85 Missing ⚠️
...ormula/src/controller/set-dependency.controller.ts 0.00% 43 Missing ⚠️
...e-formula/src/engine/dependency/dependency-tree.ts 0.00% 8 Missing ⚠️
...es/engine-formula/src/models/formula-data.model.ts 50.00% 4 Missing ⚠️
...ula/src/controller/set-other-formula.controller.ts 0.00% 2 Missing ⚠️
...ages/engine-formula/src/functions/base-function.ts 87.50% 2 Missing ⚠️
...mula/src/engine/value-object/array-value-object.ts 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1638      +/-   ##
==========================================
- Coverage   29.79%   29.71%   -0.09%     
==========================================
  Files        1173     1175       +2     
  Lines       64008    64177     +169     
  Branches    13597    13624      +27     
==========================================
- Hits        19069    19067       -2     
- Misses      44939    45110     +171     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Mar 19, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@DR-Univer DR-Univer marked this pull request as ready for review April 15, 2024 14:59
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Apr 17, 2024
@DR-Univer DR-Univer merged commit b745845 into dev Apr 18, 2024
8 checks passed
@DR-Univer DR-Univer deleted the perf-dependency-manager branch April 18, 2024 11:40
Gggpound pushed a commit that referenced this pull request Apr 22, 2024
* perf(formula): dependency maintain

* fix(formula): add dependency controller

* refactor(formula): formula data add null item

* fix(formula): formula data supports blank sheet data

* feat(sheet): support clear dependency

* perf(formula): optimize get and pick function

---------

Co-authored-by: Dushusir <1414556676@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants