Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(formula): add the Maxifs function #1711

Merged
merged 4 commits into from
Apr 9, 2024
Merged

feat(formula): add the Maxifs function #1711

merged 4 commits into from
Apr 9, 2024

Conversation

karlsbeard
Copy link
Contributor

@karlsbeard karlsbeard commented Mar 27, 2024 •
edited
Loading

  • feat: update the i18n file
  • feat: add the formula description
  • feat: add the formula algorithm
  • feat: add the unit test
  • feat: complete the function test
  • fix: change sumRange to maxRange

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 27, 2024 •
edited
Loading

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@codecov Codecov
Copy link

codecov bot commented Mar 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.45455% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 29.76%. Comparing base (1a1f7c8) to head (1e4691c).
Report is 85 commits behind head on dev.

Files Patch % Lines
...-formula/src/functions/statistical/maxifs/index.ts 85.45% 8 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #1711      +/-   ##
==========================================
- Coverage   32.78%   29.76%   -3.03%     
==========================================
  Files         952     1159     +207     
  Lines       53413    62843    +9430     
  Branches    11155    13195    +2040     
==========================================
+ Hits        17514    18703    +1189     
- Misses      35899    44140    +8241

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dushusir
Copy link
Member

very good code !

@karlsbeard karlsbeard marked this pull request as ready for review March 27, 2024 10:13
@karlsbeard karlsbeard added the qa:untested This PR is ready to be tested label Mar 27, 2024
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Apr 7, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Apr 7, 2024
wzhudev
wzhudev requested changes Apr 8, 2024
View reviewed changes
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. A minor path issue need to be fixed.

packages/engine-formula/src/functions/statistical/maxifs/__tests__/index.spec.ts Outdated Show resolved Hide resolved
packages/engine-formula/src/functions/statistical/maxifs/__tests__/index.spec.ts Outdated Show resolved Hide resolved
@karlsbeard karlsbeard requested a review from wzhudev April 9, 2024 03:42
wzhudev
wzhudev approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Well done.

@karlsbeard karlsbeard merged commit 52b2698 into dev Apr 9, 2024
8 checks passed
@karlsbeard karlsbeard deleted the feat-formula-maxifs branch April 9, 2024 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dushusir Dushusir Dushusir approved these changes

@wzhudev wzhudev wzhudev approved these changes

@jikkai jikkai Awaiting requested review from jikkai

@DR-Univer DR-Univer Awaiting requested review from DR-Univer DR-Univer is a code owner

Assignees
No one assigned
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@karlsbeard @Dushusir @wzhudev @zhaolixin7