Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine-render): ignore media change on printing mode #1808

Merged
merged 3 commits into from
Apr 7, 2024
Merged

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Apr 7, 2024

close #xxx, #yyy, #zzzz

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Apr 7, 2024
Copy link

github-actions bot commented Apr 7, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Apr 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 29.68%. Comparing base (88461d0) to head (2f9634b).

Files Patch % Lines
packages/engine-render/src/engine.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1808      +/-   ##
==========================================
- Coverage   29.68%   29.68%   -0.01%     
==========================================
  Files        1156     1156              
  Lines       62763    62764       +1     
  Branches    13175    13176       +1     
==========================================
  Hits        18634    18634              
- Misses      44129    44130       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weird94 weird94 removed the qa:untested This PR is ready to be tested label Apr 7, 2024
@weird94 weird94 merged commit f5fc6be into dev Apr 7, 2024
8 checks passed
@weird94 weird94 deleted the fix/print branch April 7, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants