Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace whitespace characters in html str #1904

Merged
merged 8 commits into from
Apr 24, 2024

Conversation

ybzky
Copy link
Member

@ybzky ybzky commented Apr 15, 2024

No description provided.

Copy link

github-actions bot commented Apr 15, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 81.03448% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 29.63%. Comparing base (761a372) to head (3f595cb).
Report is 50 commits behind head on dev.

Files Patch % Lines
packages/ui/src/utils/cell.ts 0.00% 12 Missing ⚠️
.../src/controllers/clipboard/clipboard.controller.ts 50.00% 5 Missing ⚠️
packages/core/src/shared/common.ts 0.00% 2 Missing ⚠️
...services/clipboard/html-to-usm/parse-node-style.ts 66.66% 2 Missing ⚠️
...ui/src/services/clipboard/html-to-usm/converter.ts 98.83% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1904      +/-   ##
==========================================
- Coverage   29.77%   29.63%   -0.14%     
==========================================
  Files        1173     1179       +6     
  Lines       63946    64321     +375     
  Branches    13584    13630      +46     
==========================================
+ Hits        19037    19059      +22     
- Misses      44909    45262     +353     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ybzky ybzky requested a review from DR-Univer as a code owner April 15, 2024 13:49
Copy link
Contributor

@yuhongz yuhongz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Apr 24, 2024
@ybzky ybzky merged commit 1ff1261 into dev Apr 24, 2024
8 checks passed
@ybzky ybzky deleted the fix-paste-whitespace-characters branch April 24, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants