Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sheet): force string adds popup #1934

Merged
merged 4 commits into from
Apr 23, 2024
Merged

feat(sheet): force string adds popup #1934

merged 4 commits into from
Apr 23, 2024

Conversation

Dushusir
Copy link
Member

@Dushusir Dushusir commented Apr 17, 2024

close #1921

如何测试?
输入 '1 ,hover 出现提示信息

Copy link

github-actions bot commented Apr 17, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 16.17647% with 57 lines in your changes are missing coverage. Please review.

Project coverage is 29.58%. Comparing base (d7b4772) to head (92571dc).

Files Patch % Lines
...i/src/controllers/force-string-alert.controller.ts 0.00% 30 Missing ⚠️
.../src/controllers/force-string-render.controller.ts 0.00% 23 Missing ⚠️
...ine-render/src/components/sheets/sheet-skeleton.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1934      +/-   ##
==========================================
- Coverage   29.59%   29.58%   -0.02%     
==========================================
  Files        1179     1182       +3     
  Lines       64278    64345      +67     
  Branches    13616    13629      +13     
==========================================
+ Hits        19024    19035      +11     
- Misses      45254    45310      +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dushusir Dushusir marked this pull request as ready for review April 17, 2024 04:08
@Dushusir Dushusir requested review from weird94, wzhudev and DR-Univer and removed request for Jocs, wzhudev, jikkai and DR-Univer April 17, 2024 04:08
@Dushusir Dushusir added the qa:untested This PR is ready to be tested label Apr 17, 2024
@univer-bot
Copy link

univer-bot bot commented Apr 17, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Origin Title: feat(sheet): force string adds popup

Title: feat(sheet): force string adds popup


close #1921

如何测试?
输入 '1 ,hover 出现提示信息

@Dushusir Dushusir force-pushed the dushusir/force-string branch 2 times, most recently from 6259ed5 to ccc0d82 Compare April 18, 2024 11:23
@oumomomo oumomomo added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Apr 19, 2024
@Dushusir Dushusir changed the title feat(sheet): force string add popup feat(sheet): force string adds popup Apr 20, 2024
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev merged commit add1214 into dev Apr 23, 2024
9 checks passed
@wzhudev wzhudev deleted the dushusir/force-string branch April 23, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] FORCE_STRING Shows Triangle Mark
3 participants