Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix ci playwright #2168

Merged
merged 1 commit into from
May 7, 2024
Merged

fix: fix ci playwright #2168

merged 1 commit into from
May 7, 2024

Conversation

hexf00
Copy link
Member

@hexf00 hexf00 commented May 7, 2024

https://github.com/dream-num/univer/actions/runs/8979884768/job/24662629124

ref: microsoft/playwright#29930 (comment)

exec means using the version defined in package.json, which is a recommended practice

@hexf00 hexf00 requested a review from jikkai as a code owner May 7, 2024 05:11
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label May 7, 2024
@hexf00 hexf00 removed the qa:untested This PR is ready to be tested label May 7, 2024
Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.08%. Comparing base (73e8c02) to head (264cd3d).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2168   +/-   ##
=======================================
  Coverage   31.08%   31.08%           
=======================================
  Files        1209     1209           
  Lines       66296    66296           
  Branches    14026    14026           
=======================================
  Hits        20606    20606           
  Misses      45690    45690           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 7, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@DR-Univer DR-Univer merged commit 714b244 into dev May 7, 2024
11 checks passed
@DR-Univer DR-Univer deleted the fix/ci-playwright branch May 7, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants