Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extract hooks for better customization #2301

Merged
merged 3 commits into from
May 23, 2024
Merged

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented May 23, 2024

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@wzhudev wzhudev requested review from jikkai and Jocs as code owners May 23, 2024 08:51
Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 76 lines in your changes are missing coverage. Please review.

Project coverage is 30.16%. Comparing base (e7ad8d5) to head (8aff50d).

Files Patch % Lines
packages/ui/src/views/components/doc-bars/hook.ts 0.00% 68 Missing ⚠️
...kages/ui/src/views/components/doc-bars/Toolbar.tsx 0.00% 7 Missing ⚠️
...s/ui/src/views/components/doc-bars/ToolbarItem.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2301   +/-   ##
=======================================
  Coverage   30.15%   30.16%           
=======================================
  Files        1416     1417    +1     
  Lines       72600    72589   -11     
  Branches    15212    15208    -4     
=======================================
  Hits        21894    21894           
+ Misses      50706    50695   -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 23, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@wzhudev wzhudev merged commit 2b75400 into dev May 23, 2024
8 checks passed
@wzhudev wzhudev deleted the feat/toolbar-entensive branch May 23, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant