Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formula): progress for multiple calculation #2342

Merged
merged 3 commits into from
Jun 1, 2024

Conversation

Dushusir
Copy link
Member

@Dushusir Dushusir commented May 29, 2024

  1. 有条件格式带公式的场景下,进度条有点问题,可以自建场景复测

比如 https://dev.univer.plus/sheet/?unit=jcmg_PRSTsq93LzAmT9Uwg&type=2&subunit=uni1

  1. close [Feature] Custom formula supports asynchronous requests #2331 不用QA测试

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@Dushusir Dushusir force-pushed the dushusir/progress-bar-init-cal branch from 3079fd6 to 6620f8c Compare May 29, 2024 03:40
Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 7.46269% with 62 lines in your changes are missing coverage. Please review.

Project coverage is 27.19%. Comparing base (ec2fd66) to head (33d5d59).

Files Patch % Lines
.../src/controllers/trigger-calculation.controller.ts 0.00% 53 Missing ⚠️
...ges/ui/src/components/progress-bar/ProgressBar.tsx 0.00% 7 Missing ⚠️
...kages/ui/src/services/progress/progress.service.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2342      +/-   ##
==========================================
- Coverage   27.20%   27.19%   -0.01%     
==========================================
  Files        1642     1642              
  Lines       82583    82619      +36     
  Branches    17084    17099      +15     
==========================================
+ Hits        22463    22467       +4     
- Misses      60120    60152      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 29, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@Dushusir Dushusir force-pushed the dushusir/progress-bar-init-cal branch from 6620f8c to 8b799bb Compare May 29, 2024 09:17
@Dushusir Dushusir marked this pull request as ready for review May 29, 2024 13:34
@Dushusir Dushusir force-pushed the dushusir/progress-bar-init-cal branch from cd7fbd6 to cabf87f Compare May 29, 2024 13:34
@univer-bot
Copy link

univer-bot bot commented May 29, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Origin Title: fix(formula): progress for multiple calculation

Title: fix(formula): progress for multiple calculation


  1. 有条件格式带公式的场景下,进度条有点问题,可以自建场景复测

比如 https://dev.univer.plus/sheet/?unit=jcmg_PRSTsq93LzAmT9Uwg&type=2&subunit=uni1

  1. close [Feature] Custom formula supports asynchronous requests #2331 不用QA测试

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@Dushusir Dushusir added the qa:untested This PR is ready to be tested label May 29, 2024
@Dushusir Dushusir force-pushed the dushusir/progress-bar-init-cal branch from 922b012 to 61be3e8 Compare May 30, 2024 04:01
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Jun 1, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Jun 1, 2024
@Dushusir Dushusir force-pushed the dushusir/progress-bar-init-cal branch from 61be3e8 to 33d5d59 Compare June 1, 2024 08:01
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev merged commit 1169af4 into dev Jun 1, 2024
9 checks passed
@wzhudev wzhudev deleted the dushusir/progress-bar-init-cal branch June 1, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Custom formula supports asynchronous requests
3 participants