Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sync actions between formula editor and cell editor #2380

Merged
merged 5 commits into from
Jun 4, 2024
Merged

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Jun 1, 2024

close https://github.com/dream-num/univer-pro/issues/1021

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

codecov bot commented Jun 1, 2024

Codecov Report

Attention: Patch coverage is 3.52941% with 82 lines in your changes are missing coverage. Please review.

Project coverage is 27.11%. Comparing base (f339ebd) to head (3f203da).

Files Patch % Lines
...rc/controllers/editor/formula-editor.controller.ts 0.00% 71 Missing ⚠️
.../engine-render/src/components/docs/layout/tools.ts 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2380      +/-   ##
==========================================
- Coverage   27.13%   27.11%   -0.02%     
==========================================
  Files        1646     1646              
  Lines       83042    83095      +53     
  Branches    17203    17215      +12     
==========================================
  Hits        22534    22534              
- Misses      60508    60561      +53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 1, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@Jocs Jocs marked this pull request as ready for review June 1, 2024 08:19
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Jun 1, 2024
@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Jun 3, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Jun 3, 2024
@Jocs Jocs merged commit bdf033c into dev Jun 4, 2024
9 checks passed
@Jocs Jocs deleted the fix/fx-edit branch June 4, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants