Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): fix flickering on register ui parts #2430

Merged
merged 4 commits into from
Jun 5, 2024
Merged

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Jun 5, 2024

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@wzhudev wzhudev requested review from jikkai and Jocs as code owners June 5, 2024 12:33
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 27.13%. Comparing base (c659971) to head (a89d487).
Report is 2 commits behind head on dev.

Files Patch % Lines
packages/ui/src/views/App.tsx 0.00% 7 Missing ⚠️
packages/ui/src/services/parts/parts.service.ts 0.00% 5 Missing ⚠️
...ges/ui/src/views/components/ComponentContainer.tsx 0.00% 2 Missing ⚠️
packages/ui/src/views/parts.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2430   +/-   ##
=======================================
  Coverage   27.13%   27.13%           
=======================================
  Files        1646     1646           
  Lines       83037    83040    +3     
  Branches    17208    17211    +3     
=======================================
+ Hits        22535    22536    +1     
- Misses      60502    60504    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 5, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@wzhudev wzhudev merged commit 2d036a3 into dev Jun 5, 2024
9 checks passed
@wzhudev wzhudev deleted the wzhudev/fix/flick branch June 5, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant