Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheets-data-validation): build error #2436

Merged
merged 1 commit into from
Jun 6, 2024
Merged

fix(sheets-data-validation): build error #2436

merged 1 commit into from
Jun 6, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Jun 6, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@weird94 weird94 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Jun 6, 2024
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 27.18%. Comparing base (5b7bc17) to head (d73ff4c).

Files Patch % Lines
packages/engine-render/src/context.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2436      +/-   ##
==========================================
+ Coverage   27.16%   27.18%   +0.01%     
==========================================
  Files        1649     1649              
  Lines       83034    83034              
  Branches    17190    17190              
==========================================
+ Hits        22558    22569      +11     
+ Misses      60476    60465      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weird94 weird94 merged commit d497b03 into dev Jun 6, 2024
13 checks passed
@weird94 weird94 deleted the fix/dv-build-error branch June 6, 2024 11:51
Copy link

github-actions bot commented Jun 6, 2024

View Deployment

#9400343344

🥐 🍔 🥓 🥗 🥘 🌯 🍚 🍛 🍖 🍭 🍧 🍝 🥪 🥖 🍪
Still cooking, please come back later
🥙 🥮 🥨 🌭 🍦 🍙 🍕 🍰 🍮 🍜 🍡 🍱 🍿 🍕 🥟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants