-
-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sheets-hyper-link): skip error on ref-range mutation #2446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #2446 +/- ##
==========================================
- Coverage 27.12% 27.12% -0.01%
==========================================
Files 1653 1653
Lines 83302 83307 +5
Branches 17255 17257 +2
==========================================
- Hits 22595 22594 -1
- Misses 60707 60713 +6 ☔ View full report in Codecov by Sentry. |
View Deployment
🥐 🍔 🥓 🥗 🥘 🌯 🍚 🍛 🍖 🍭 🍧 🍝 🥪 🥖 🍪 |
…r into fix/hyper-link-ref-range
wzhudev
approved these changes
Jun 11, 2024
lumixraku
pushed a commit
that referenced
this pull request
Jun 17, 2024
* feat: skip error on ref-range mutation * feat: i18n * feat: update * fix: intersets * feat: style * feat: remove skip error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When both position and payload of hyperlink refer to same area, when delete this area, update-link-mutation will return false cause the link is deleted. This case should be ignored.
close #xxx
Pull Request Checklist