Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formula): subtotal count #2452

Merged
merged 11 commits into from
Jun 21, 2024
Merged

fix(formula): subtotal count #2452

merged 11 commits into from
Jun 21, 2024

Conversation

Dushusir
Copy link
Member

@Dushusir Dushusir commented Jun 7, 2024

close #2018
close #2035
close #2038
close #2141
close #698


close #2129 close #755 (这些 issue 在以前的PR中附带修复,可以一起测试下)

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@Dushusir Dushusir force-pushed the dushusir/fix-formula-bugs0607 branch from 51f6832 to aa2dc54 Compare June 7, 2024 09:31
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 43.63636% with 31 lines in your changes missing coverage. Please review.

Project coverage is 27.19%. Comparing base (f49fed1) to head (0282dbe).
Report is 2 commits behind head on dev.

Current head 0282dbe differs from pull request most recent head 433410c

Please upload reports for the commit 433410c to get more accurate results.

Files Patch % Lines
...la/src/controllers/formula-clipboard.controller.ts 30.76% 27 Missing ⚠️
...ormula/src/engine/dependency/formula-dependency.ts 0.00% 2 Missing ⚠️
...on/sheet-permission-interceptor-base.controller.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2452      +/-   ##
==========================================
+ Coverage   27.06%   27.19%   +0.13%     
==========================================
  Files        1677     1653      -24     
  Lines       84765    83620    -1145     
  Branches    17626    17405     -221     
==========================================
- Hits        22938    22740     -198     
+ Misses      61827    60880     -947     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 7, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@Dushusir Dushusir force-pushed the dushusir/fix-formula-bugs0607 branch from 5719293 to bcde98f Compare June 11, 2024 08:00
@Dushusir Dushusir marked this pull request as ready for review June 12, 2024 08:36
@Dushusir Dushusir requested a review from DR-Univer as a code owner June 12, 2024 08:36
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Jun 12, 2024
@univer-bot
Copy link

univer-bot bot commented Jun 12, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Origin Title: fix(formula): subtotal count

Title: fix(formula): subtotal count


close #2018
close #2035
close #2038
close #2141
close #698


close #2129 close #755 (这些 issue 在以前的PR中附带修复,可以一起测试下)

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@Dushusir Dushusir force-pushed the dushusir/fix-formula-bugs0607 branch 3 times, most recently from 093efd1 to 83be606 Compare June 17, 2024 12:19
@oumomomo
Copy link

#2141
局部样式粘贴为公式时,还是会携带样式
image

@univer-bot
Copy link

univer-bot bot commented Jun 18, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

#2141
When the local style is pasted as a formula, the style will still be carried
image

@Dushusir
Copy link
Member Author

Dushusir commented Jun 18, 2024

#2141 局部样式粘贴为公式时,还是会携带样式 image

fixed

@univer-bot
Copy link

univer-bot bot commented Jun 18, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

#2141 Image -b0f1-cd6ab8be58b7.png?jwt =eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTg3MTQ5NDIs Im5iZiI6MTcxODcxNDY0MiwicGF0aCI6Ii8xNjcxNzEzNTYvMzQwNjY4ODA4LTY1MzM1OWFmLTg0YjYtNGI3ZC1iMGYxLWNkNmFiOGJlNThiNy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE 1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMj QwNjE4JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MD YxOFQxMjQ0MDJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0xODQ4NzNmMzljOTAwYjVlOTUxYmNhNDI3NmMyZDFiN2E4MWMyNDk4NjAwNzgyMmY2YmI1Mzk3Mzdi NTRkMGQ2JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.e6PuEIzCQNDcNJDgOT2kcrQLTH1AeZiwnfqmZtm3ej4)

fixed

@oumomomo oumomomo added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Jun 21, 2024
@Dushusir Dushusir force-pushed the dushusir/fix-formula-bugs0607 branch from faf1b21 to 433410c Compare June 21, 2024 11:41
@Dushusir Dushusir merged commit 61de312 into dev Jun 21, 2024
2 checks passed
@Dushusir Dushusir deleted the dushusir/fix-formula-bugs0607 branch June 21, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
3 participants