Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only users with editing permissions can join the protected colla… #2504

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

ybzky
Copy link
Member

@ybzky ybzky commented Jun 13, 2024

…boration

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 27.12%. Comparing base (b3393ef) to head (254becd).

Files Patch % Lines
...kages/sheets-ui/src/controllers/menu/sheet.menu.ts 0.00% 1 Missing ⚠️
...eets-ui/src/views/permission/user-dialog/index.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2504      +/-   ##
==========================================
- Coverage   27.12%   27.12%   -0.01%     
==========================================
  Files        1653     1653              
  Lines       83328    83328              
  Branches    17260    17260              
==========================================
- Hits        22605    22604       -1     
- Misses      60723    60724       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 13, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@ybzky ybzky merged commit 2ea683e into dev Jun 13, 2024
9 checks passed
@ybzky ybzky deleted the fix-permission-person branch June 13, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants