fix: button style #2541
Merged
fix: button style #2541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #2541 +/- ##
=======================================
Coverage 27.16% 27.16%
=======================================
Files 1653 1653
Lines 83508 83562 +54
Branches 17368 17384 +16
=======================================
+ Hits 22685 22701 +16
- Misses 60823 60861 +38 ☔ View full report in Codecov by Sentry. |
View Deployment
|
oumomomo
added
the
qa:verified
wzhudev
added a commit
that referenced
this pull request
Jul 8, 2024
refactor(docs-ui): refactor doc rendering to render unit fix: fix error emitted refactor: refactor zoom controller refactor: refactor back scroll render controller refactor: move doc skeleton manager into render unit refactor: refactor doc drawing refactor: refactor editor related modules fix: fix type error WIP refactor: refactor doc view model test: fix docs test fix: fix import error test: fix facade test fix: fix e2e test chore: change editor unit name chore: update code style fix: fix formula editor cannot be activated fix: fix render blinking fix: fix sheet editor cannot be updated fix: button style (#2541) * fix(sheet): style issue * chore: range modal delete button style chore: update dependencies & limit maximum concurrency for turbo execution (#2543) fix(sheets-ui): fix unhide render controller RENDER_COMMANDS (#2516) fix(sheets): hide rows cols should skip over already hidden ranges (#2517) fix: use @univerjs/ui useObservable (#2456) fix(design): fix popup position (#2510) fix(sheets-drawing-ui): error delete cache when float-dom hide (#2540) feat: everything feels very lag when there is a long range dashrect(cliparea) (#2472) * fix: moving getCell lower * fix: try to draw dashrect in visible area * chore: rm useless * fix: do not use startXY as IRect props to get viewport pos fix(sheets): fix some bugs (#2545) * fix(sheets): fix some bugs * chore: change test * fix: bugfix chore(ci): fix sync:cnpm (#2525) feat: init uni mode ui layout fix: fix scroll problems fix: fix sheet bar tabs feat: add focus style fix: all workbooks need to initialized fix: fix zoom slider chore: clean code fix: fix editor position
wzhudev
added a commit
that referenced
this pull request
Jul 8, 2024
refactor(docs-ui): refactor doc rendering to render unit fix: fix error emitted refactor: refactor zoom controller refactor: refactor back scroll render controller refactor: move doc skeleton manager into render unit refactor: refactor doc drawing refactor: refactor editor related modules fix: fix type error WIP refactor: refactor doc view model test: fix docs test fix: fix import error test: fix facade test fix: fix e2e test chore: change editor unit name chore: update code style fix: fix formula editor cannot be activated fix: fix render blinking fix: fix sheet editor cannot be updated fix: button style (#2541) * fix(sheet): style issue * chore: range modal delete button style chore: update dependencies & limit maximum concurrency for turbo execution (#2543) fix(sheets-ui): fix unhide render controller RENDER_COMMANDS (#2516) fix(sheets): hide rows cols should skip over already hidden ranges (#2517) fix: use @univerjs/ui useObservable (#2456) fix(design): fix popup position (#2510) fix(sheets-drawing-ui): error delete cache when float-dom hide (#2540) feat: everything feels very lag when there is a long range dashrect(cliparea) (#2472) * fix: moving getCell lower * fix: try to draw dashrect in visible area * chore: rm useless * fix: do not use startXY as IRect props to get viewport pos fix(sheets): fix some bugs (#2545) * fix(sheets): fix some bugs * chore: change test * fix: bugfix chore(ci): fix sync:cnpm (#2525) feat: init uni mode ui layout fix: fix scroll problems fix: fix sheet bar tabs feat: add focus style fix: all workbooks need to initialized fix: fix zoom slider chore: clean code fix: fix editor position
wzhudev
added a commit
that referenced
this pull request
Jul 8, 2024
refactor(docs-ui): refactor doc rendering to render unit fix: fix error emitted refactor: refactor zoom controller refactor: refactor back scroll render controller refactor: move doc skeleton manager into render unit refactor: refactor doc drawing refactor: refactor editor related modules fix: fix type error WIP refactor: refactor doc view model test: fix docs test fix: fix import error test: fix facade test fix: fix e2e test chore: change editor unit name chore: update code style fix: fix formula editor cannot be activated fix: fix render blinking fix: fix sheet editor cannot be updated fix: button style (#2541) * fix(sheet): style issue * chore: range modal delete button style chore: update dependencies & limit maximum concurrency for turbo execution (#2543) fix(sheets-ui): fix unhide render controller RENDER_COMMANDS (#2516) fix(sheets): hide rows cols should skip over already hidden ranges (#2517) fix: use @univerjs/ui useObservable (#2456) fix(design): fix popup position (#2510) fix(sheets-drawing-ui): error delete cache when float-dom hide (#2540) feat: everything feels very lag when there is a long range dashrect(cliparea) (#2472) * fix: moving getCell lower * fix: try to draw dashrect in visible area * chore: rm useless * fix: do not use startXY as IRect props to get viewport pos fix(sheets): fix some bugs (#2545) * fix(sheets): fix some bugs * chore: change test * fix: bugfix chore(ci): fix sync:cnpm (#2525) feat: init uni mode ui layout fix: fix scroll problems fix: fix sheet bar tabs feat: add focus style fix: all workbooks need to initialized fix: fix zoom slider chore: clean code fix: fix editor position
wzhudev
added a commit
that referenced
this pull request
Jul 8, 2024
refactor(docs-ui): refactor doc rendering to render unit fix: fix error emitted refactor: refactor zoom controller refactor: refactor back scroll render controller refactor: move doc skeleton manager into render unit refactor: refactor doc drawing refactor: refactor editor related modules fix: fix type error WIP refactor: refactor doc view model test: fix docs test fix: fix import error test: fix facade test fix: fix e2e test chore: change editor unit name chore: update code style fix: fix formula editor cannot be activated fix: fix render blinking fix: fix sheet editor cannot be updated fix: button style (#2541) * fix(sheet): style issue * chore: range modal delete button style chore: update dependencies & limit maximum concurrency for turbo execution (#2543) fix(sheets-ui): fix unhide render controller RENDER_COMMANDS (#2516) fix(sheets): hide rows cols should skip over already hidden ranges (#2517) fix: use @univerjs/ui useObservable (#2456) fix(design): fix popup position (#2510) fix(sheets-drawing-ui): error delete cache when float-dom hide (#2540) feat: everything feels very lag when there is a long range dashrect(cliparea) (#2472) * fix: moving getCell lower * fix: try to draw dashrect in visible area * chore: rm useless * fix: do not use startXY as IRect props to get viewport pos fix(sheets): fix some bugs (#2545) * fix(sheets): fix some bugs * chore: change test * fix: bugfix chore(ci): fix sync:cnpm (#2525) feat: init uni mode ui layout fix: fix scroll problems fix: fix sheet bar tabs feat: add focus style fix: all workbooks need to initialized fix: fix zoom slider chore: clean code fix: fix editor position
wzhudev
added a commit
that referenced
this pull request
Jul 8, 2024
refactor(docs-ui): refactor doc rendering to render unit fix: fix error emitted refactor: refactor zoom controller refactor: refactor back scroll render controller refactor: move doc skeleton manager into render unit refactor: refactor doc drawing refactor: refactor editor related modules fix: fix type error WIP refactor: refactor doc view model test: fix docs test fix: fix import error test: fix facade test fix: fix e2e test chore: change editor unit name chore: update code style fix: fix formula editor cannot be activated fix: fix render blinking fix: fix sheet editor cannot be updated fix: button style (#2541) * fix(sheet): style issue * chore: range modal delete button style chore: update dependencies & limit maximum concurrency for turbo execution (#2543) fix(sheets-ui): fix unhide render controller RENDER_COMMANDS (#2516) fix(sheets): hide rows cols should skip over already hidden ranges (#2517) fix: use @univerjs/ui useObservable (#2456) fix(design): fix popup position (#2510) fix(sheets-drawing-ui): error delete cache when float-dom hide (#2540) feat: everything feels very lag when there is a long range dashrect(cliparea) (#2472) * fix: moving getCell lower * fix: try to draw dashrect in visible area * chore: rm useless * fix: do not use startXY as IRect props to get viewport pos fix(sheets): fix some bugs (#2545) * fix(sheets): fix some bugs * chore: change test * fix: bugfix chore(ci): fix sync:cnpm (#2525) feat: init uni mode ui layout fix: fix scroll problems fix: fix sheet bar tabs feat: add focus style fix: all workbooks need to initialized fix: fix zoom slider chore: clean code fix: fix editor position
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #242
Pull Request Checklist