Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(UMD): add sort umd #2581

Merged
merged 1 commit into from
Jun 21, 2024
Merged

feat(UMD): add sort umd #2581

merged 1 commit into from
Jun 21, 2024

Conversation

hexf00
Copy link
Member

@hexf00 hexf00 commented Jun 21, 2024

  • fix: ui dependency in sort

  • chore: lock

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@hexf00 hexf00 changed the title fix(sheet): ui dependency in sort (#2580) fix(UMD): add sort umd Jun 21, 2024
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.06%. Comparing base (1c67036) to head (f957f87).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2581      +/-   ##
==========================================
+ Coverage   27.04%   27.06%   +0.01%     
==========================================
  Files        1677     1677              
  Lines       84765    84765              
  Branches    17626    17626              
==========================================
+ Hits        22928    22938      +10     
+ Misses      61837    61827      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 21, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@hexf00 hexf00 marked this pull request as ready for review June 21, 2024 05:58
@hexf00 hexf00 changed the title fix(UMD): add sort umd feat(UMD): add sort umd Jun 21, 2024
@hexf00 hexf00 merged commit f49fed1 into dev Jun 21, 2024
11 checks passed
@hexf00 hexf00 deleted the feat/umd-sort branch June 21, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants