Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: icon set dropdown style #2602

Merged
merged 7 commits into from
Jun 24, 2024
Merged

fix: icon set dropdown style #2602

merged 7 commits into from
Jun 24, 2024

Conversation

siam-ese
Copy link
Contributor

close https://github.com/dream-num/univer-workspace/issues/289

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Jun 24, 2024
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 27.12%. Comparing base (2d5de98) to head (1b8855d).

Files Patch % Lines
packages/ui/src/components/hooks/layout.ts 0.00% 7 Missing ⚠️
...ting-ui/src/components/panel/rule-edit/iconSet.tsx 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2602   +/-   ##
=======================================
  Coverage   27.12%   27.12%           
=======================================
  Files        1675     1675           
  Lines       84653    84647    -6     
  Branches    17642    17642           
=======================================
  Hits        22961    22961           
+ Misses      61692    61686    -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 24, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Jun 24, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Jun 24, 2024
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev merged commit c6e23cd into dev Jun 24, 2024
9 checks passed
@wzhudev wzhudev deleted the fix/icon-dropdown-style branch June 24, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants