feat(formula): add logical functions #2644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View Deployment
|
Dushusir
requested changes
Jul 1, 2024
| expect(result.getValue()).toBe(ErrorType.NAME); | ||
| }); | ||
|
|
||
| it('Value is array', () => { |
There was a problem hiding this comment.
Need to support array formulas, like
Dushusir
requested changes
Jul 1, 2024
| import { type BaseValueObject, ErrorValueObject } from '../../../engine/value-object/base-value-object'; | ||
| import { BaseFunction } from '../../base-function'; | ||
|
|
||
| export class Ifs extends BaseFunction { |
There was a problem hiding this comment.
Formulas with multiple input parameters need to consider array expansion. For expansion of ranges of different sizes, refer to the use of expandArrayValueObject method.
Dushusir
reviewed
Jul 1, 2024
| import { BooleanValueObject } from '../../../engine/value-object/primitive-object'; | ||
| import { BaseFunction } from '../../base-function'; | ||
|
|
||
| export class Not extends BaseFunction { |
Dushusir
reviewed
Jul 1, 2024
|
|
||
| override maxParams = 255; | ||
|
|
||
| override calculate(expression: BaseValueObject, ...casesAndResults: BaseValueObject[]): BaseValueObject { |
There was a problem hiding this comment.
Need to support array formulas, like
Dushusir
reviewed
Jul 1, 2024
| import { BaseFunction } from '../../base-function'; | ||
|
|
||
| export class Xor extends BaseFunction { | ||
| override minParams = 1; |
There was a problem hiding this comment.
=XOR(C1:C3>0,E1:G1<10,J1:J4) gets TRUE
There was a problem hiding this comment.
@Hossein-Khan Still need to be resolved
There was a problem hiding this comment.
Sure, could you please explain more about what the issue is with the XOR function?
|
Please pay attention to the failure CI |
zhaolixin7
added
the
qa:verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds implementations for the following logical functions:
Changes