Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sheet): restart formula calculation #2646

Merged
merged 4 commits into from
Jul 2, 2024
Merged

Conversation

DR-Univer
Copy link
Collaborator

@DR-Univer DR-Univer commented Jun 30, 2024

close #2037
close #2101

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

codecov bot commented Jun 30, 2024

Codecov Report

Attention: Patch coverage is 3.92157% with 49 lines in your changes missing coverage. Please review.

Project coverage is 27.37%. Comparing base (909f2ee) to head (6e9db1e).
Report is 6 commits behind head on dev.

Files Patch % Lines
.../src/controllers/trigger-calculation.controller.ts 0.00% 35 Missing ⚠️
...ges/engine-formula/src/services/runtime.service.ts 16.66% 5 Missing ⚠️
...-formula/src/services/calculate-formula.service.ts 0.00% 3 Missing ⚠️
...gine-render/src/components/sheets/column-header.ts 0.00% 2 Missing ⚠️
.../engine-render/src/components/sheets/row-header.ts 0.00% 2 Missing ⚠️
...engine-render/src/components/sheets/spreadsheet.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2646      +/-   ##
==========================================
- Coverage   27.40%   27.37%   -0.04%     
==========================================
  Files        1707     1707              
  Lines       85677    85838     +161     
  Branches    17906    17930      +24     
==========================================
+ Hits        23481    23498      +17     
- Misses      62196    62340     +144     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 30, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@DR-Univer DR-Univer changed the title feat(sheet): restart sheet feat(sheet): restart formula calculation Jul 1, 2024
@DR-Univer DR-Univer added the qa:untested This PR is ready to be tested label Jul 1, 2024
@DR-Univer DR-Univer force-pushed the feat-formula-restart-support branch from 83d893b to 66191e4 Compare July 1, 2024 12:30
@DR-Univer DR-Univer requested a review from lumixraku as a code owner July 1, 2024 12:37
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Jul 2, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Jul 2, 2024
@DR-Univer DR-Univer merged commit b1be75c into dev Jul 2, 2024
10 checks passed
@DR-Univer DR-Univer deleted the feat-formula-restart-support branch July 2, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
3 participants