Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: scroll and selection for mobile version #2657

Merged
merged 10 commits into from
Jul 3, 2024
Merged

feat: scroll and selection for mobile version #2657

merged 10 commits into from
Jul 3, 2024

Conversation

lumixraku
Copy link
Contributor

@lumixraku lumixraku commented Jul 2, 2024 •
edited
Loading

close https://github.com/dream-num/univer-pro/issues/1148

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@lumixraku lumixraku self-assigned this Jul 2, 2024
@lumixraku lumixraku changed the title feat: scroll & selection for mobile feat: scroll and selection for mobile version Jul 2, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 4.46590% with 1583 lines in your changes missing coverage. Please review.

Project coverage is 26.93%. Comparing base (7d35091) to head (7295d5c).
Report is 1 commits behind head on dev.

Files Patch % Lines
...vices/selection/mobile-selection-render.service.ts 0.00% 579 Missing ⚠️
...trollers/mobile/mobile-scroll.render-controller.ts 0.00% 311 Missing ⚠️
...llers/mobile/mobile-selection.render-controller.ts 0.00% 271 Missing ⚠️
...i/src/services/selection/mobile-selection-shape.ts 0.00% 120 Missing ⚠️
packages/engine-render/src/shape/dashedrect.ts 0.00% 49 Missing ⚠️
...heets-ui/src/services/selection/selection-shape.ts 42.18% 37 Missing ⚠️
...ers/mobile/mobile-contextmenu.render-controller.ts 0.00% 30 Missing ⚠️
packages/engine-render/src/scene.input-manager.ts 0.00% 25 Missing ⚠️
packages/engine-render/src/viewport.ts 0.00% 25 Missing ⚠️
...s/sheets/src/services/selection-manager.service.ts 26.47% 25 Missing ⚠️
... and 22 more
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #2657      +/-   ##
==========================================
- Coverage   27.36%   26.93%   -0.44%     
==========================================
  Files        1709     1714       +5     
  Lines       86066    87499    +1433     
  Branches    17985    18327     +342     
==========================================
+ Hits        23551    23564      +13     
- Misses      62515    63935    +1420

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lumixraku lumixraku force-pushed the feat/scroll-mobile-merge branch 2 times, most recently from db68deb to 7c5d845 Compare July 2, 2024 08:48
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 2, 2024 •
edited
Loading

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@lumixraku lumixraku added the qa:untested This PR is ready to be tested label Jul 2, 2024
@lumixraku lumixraku marked this pull request as ready for review July 2, 2024 09:50
@lumixraku lumixraku force-pushed the feat/scroll-mobile-merge branch 2 times, most recently from 4a178f8 to 5cf8178 Compare July 2, 2024 12:16
@lumixraku
feat: start new selection when pointerup
df4b901 
feat: rename evenrtrigger

refactor: use mobile render controller & rename some method

test: expanding selection but can not shrink?

test: fix cannot shrink

fix: can shrink!!

test: fix shrink 3

chore: use mobile-selection-shape.ts

fix: add selectionMoveEnd$ back, then fix mobile selection popup

chore: rename

chore: better shape style

fix: popup position when scrolled

chore: add rangetype when update control

fix: moving control for middle ltrb

fix: row & col expand range

chore: move dash logic into dashedrect

test: change selection shape Y when scrolling

feat: use scrollInfo$ to control scrolling

feat: fix event after merge
@lumixraku
fix: init scrollXY when create row & col seleciton
487174f 
fix: cross viewport selection exclude row & col

fix: use validScrollInfo$
@lumixraku
fix: pointer scroll by cmd also
5994c05 
fix: context menu for row & col

fix: rawScrollInfo$ should get skelenton again

fix: change sheet tab init scrolling info
@lumixraku
fix: restore selection state when switching sub sheet unit
7b707ce
@lumixraku
feat: add longpress to create selection
3e2cd5e 
fix: longpress show menu

test: just test
@lumixraku
fix: contextmenu position & control pointe pos of row & col
3e3bcfb
@lumixraku
chore: eslint fix
c576659
@lumixraku
chore: vitest fix
722c9f2
@lumixraku
chore: rm useless
a9c7b8a
@lumixraku
chore: contextmenu pos
7295d5c
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Jul 3, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Jul 3, 2024
wzhudev
wzhudev approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev merged commit 62e5b64 into dev Jul 3, 2024
9 checks passed
@wzhudev wzhudev deleted the feat/scroll-mobile-merge branch July 3, 2024 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wzhudev wzhudev wzhudev approved these changes

@DR-Univer DR-Univer Awaiting requested review from DR-Univer

@Dushusir Dushusir Awaiting requested review from Dushusir Dushusir is a code owner

@jikkai jikkai Awaiting requested review from jikkai jikkai is a code owner

@hexf00 hexf00 Awaiting requested review from hexf00 hexf00 is a code owner

Assignees

@lumixraku lumixraku

Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lumixraku @wzhudev @zhaolixin7