Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(slides): add sidebar highlighting for selected items in slides #2691

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

jikkai
Copy link
Member

@jikkai jikkai commented Jul 5, 2024

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@jikkai jikkai requested a review from DR-Univer as a code owner July 5, 2024 08:10
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 47.05882% with 9 lines in your changes missing coverage. Please review.

Project coverage is 26.92%. Comparing base (a2fd4ed) to head (83019fa).

Files Patch % Lines
...ackages/slides-ui/src/views/slide-bar/SlideBar.tsx 0.00% 7 Missing ⚠️
packages/slides/src/views/render/canvas-view.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2691   +/-   ##
=======================================
  Coverage   26.92%   26.92%           
=======================================
  Files        1636     1636           
  Lines       87997    88008   +11     
  Branches    18554    18554           
=======================================
+ Hits        23695    23699    +4     
- Misses      64302    64309    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jul 5, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@jikkai jikkai merged commit 04fbb05 into dev Jul 5, 2024
9 checks passed
@jikkai jikkai deleted the feat/slide-sidebar branch July 5, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant