Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheet): drawing load #2692

Merged
merged 8 commits into from
Jul 5, 2024
Merged

fix(sheet): drawing load #2692

merged 8 commits into from
Jul 5, 2024

Conversation

DR-Univer
Copy link
Collaborator

@DR-Univer DR-Univer commented Jul 5, 2024

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

codecov bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 26.69%. Comparing base (a2fd4ed) to head (772146b).
Report is 2 commits behind head on dev.

Files Patch % Lines
...rawing/src/controllers/sheet-drawing.controller.ts 0.00% 12 Missing ⚠️
...awing/src/services/drawing-manager-impl.service.ts 0.00% 6 Missing ⚠️
...src/controllers/sheet-drawing-update.controller.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2692      +/-   ##
==========================================
- Coverage   26.92%   26.69%   -0.24%     
==========================================
  Files        1636     1643       +7     
  Lines       87997    88816     +819     
  Branches    18554    18747     +193     
==========================================
+ Hits        23695    23711      +16     
- Misses      64302    65105     +803     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jul 5, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@DR-Univer DR-Univer merged commit 2c5011e into dev Jul 5, 2024
9 checks passed
@DR-Univer DR-Univer deleted the fix-sheet-drawing-load branch July 5, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants