Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sidebar-service supports scroll-event subscription #2724

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

yuhongz
Copy link
Contributor

@yuhongz yuhongz commented Jul 9, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@yuhongz yuhongz requested review from jikkai and Jocs as code owners July 9, 2024 01:44
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 26.24%. Comparing base (2f99d19) to head (06ea09c).

Files Patch % Lines
...ckages/ui/src/views/components/sidebar/Sidebar.tsx 0.00% 9 Missing ⚠️
...ui/src/services/sidebar/desktop-sidebar.service.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2724      +/-   ##
==========================================
- Coverage   26.24%   26.24%   -0.01%     
==========================================
  Files        1684     1684              
  Lines       89163    89173      +10     
  Branches    18782    18783       +1     
==========================================
  Hits        23405    23405              
- Misses      65758    65768      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jul 9, 2024

View Deployment

#9852417376

🥐 🍔 🥓 🥗 🥘 🌯 🍚 🍛 🍖 🍭 🍧 🍝 🥪 🥖 🍪
Still cooking, please come back later
🥙 🥮 🥨 🌭 🍦 🍙 🍕 🍰 🍮 🍜 🍡 🍱 🍿 🍕 🥟

@yuhongz yuhongz merged commit 2da550d into dev Jul 9, 2024
9 checks passed
@yuhongz yuhongz deleted the yuhongz/sidebar-scroll branch July 9, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants