Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheets-ui): bugfix for data-validation/comments #2734

Merged
merged 49 commits into from
Jul 15, 2024
Merged

fix(sheets-ui): bugfix for data-validation/comments #2734

merged 49 commits into from
Jul 15, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Jul 10, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 13.82114% with 212 lines in your changes missing coverage. Please review.

Project coverage is 26.29%. Comparing base (d47f195) to head (5083d2b).
Report is 4 commits behind head on dev.

Files Patch % Lines
...rc/controllers/sheets-thread-comment.controller.ts 0.00% 36 Missing ⚠️
...trollers/doc-hyper-link-custom-range.controller.ts 0.00% 22 Missing ⚠️
...ocs-ui/src/services/clipboard/clipboard.service.ts 0.00% 20 Missing ⚠️
...er-link-ui/src/controllers/set-range.controller.ts 0.00% 19 Missing ⚠️
...omment-ui/src/views/thread-comment-panel/index.tsx 0.00% 14 Missing ⚠️
...nt/src/views/sheets-thread-comment-panel/index.tsx 0.00% 12 Missing ⚠️
...controllers/doc-hyper-link-clipboard.controller.ts 0.00% 11 Missing ⚠️
...rollers/doc-thread-comment-selection.controller.ts 0.00% 5 Missing ⚠️
...ui/src/services/clipboard/html-to-udm/converter.ts 37.50% 5 Missing ⚠️
...kages/docs/src/commands/commands/delete.command.ts 0.00% 5 Missing ⚠️
... and 28 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2734      +/-   ##
==========================================
+ Coverage   25.98%   26.29%   +0.31%     
==========================================
  Files        1695     1706      +11     
  Lines       90709    91390     +681     
  Branches    19137    19345     +208     
==========================================
+ Hits        23569    24035     +466     
- Misses      67140    67355     +215     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jul 10, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@weird94 weird94 requested a review from DR-Univer as a code owner July 10, 2024 11:41
@weird94 weird94 requested a review from lumixraku as a code owner July 10, 2024 13:28
@weird94 weird94 requested a review from yuhongz as a code owner July 11, 2024 03:32
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Jul 15, 2024
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev merged commit 75bb1f6 into dev Jul 15, 2024
9 checks passed
@wzhudev wzhudev deleted the fix/zw-0709 branch July 15, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants