Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheets-hyper-link-ui): popup observable error on react16 #2755

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Jul 12, 2024

close #2716

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 25.98%. Comparing base (a1a3dbc) to head (4db3396).

Files Patch % Lines
...ts-hyper-link-ui/src/views/CellLinkPopup/index.tsx 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2755      +/-   ##
==========================================
- Coverage   25.98%   25.98%   -0.01%     
==========================================
  Files        1695     1695              
  Lines       90703    90709       +6     
  Branches    19137    19137              
==========================================
  Hits        23569    23569              
- Misses      67134    67140       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Jul 12, 2024
Copy link

github-actions bot commented Jul 12, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@jikkai jikkai removed the qa:untested This PR is ready to be tested label Jul 12, 2024
@jikkai jikkai merged commit f0edc5b into dev Jul 12, 2024
10 checks passed
@jikkai jikkai deleted the fix/link-popup branch July 12, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] After using the hyperlink package, if you are using react17, the hyperlink will become invalid.
2 participants