Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(design): add class name as poperty of select list #2788

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

VicKun4937
Copy link
Contributor

  • add some optional property for custom css

@VicKun4937 VicKun4937 requested a review from jikkai as a code owner July 16, 2024 13:14
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 26.30%. Comparing base (de05ff8) to head (e0be1df).
Report is 3 commits behind head on dev.

Files Patch % Lines
...s/design/src/components/select-list/SelectList.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2788      +/-   ##
==========================================
+ Coverage   26.28%   26.30%   +0.02%     
==========================================
  Files        1707     1709       +2     
  Lines       91478    91499      +21     
  Branches    19368    19369       +1     
==========================================
+ Hits        24046    24070      +24     
+ Misses      67432    67429       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jul 16, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@VicKun4937 VicKun4937 requested a review from jikkai July 17, 2024 03:18
Copy link
Member

@jikkai jikkai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jikkai jikkai merged commit f78b538 into dev Jul 17, 2024
9 checks passed
@jikkai jikkai deleted the feat/desgin-select-list branch July 17, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants