Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: min cursor height and move cursor #2789

Merged
merged 1 commit into from
Jul 16, 2024
Merged

fix: min cursor height and move cursor #2789

merged 1 commit into from
Jul 16, 2024

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Jul 16, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@Jocs Jocs marked this pull request as ready for review July 16, 2024 13:16
@Jocs Jocs requested review from DR-Univer and lumixraku as code owners July 16, 2024 13:16
@Jocs Jocs requested a review from weird94 July 16, 2024 13:19
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 26.29%. Comparing base (de05ff8) to head (c7829bd).

Files Patch % Lines
...r/src/components/docs/text-selection/text-range.ts 0.00% 6 Missing ⚠️
...ges/docs/src/controllers/move-cursor.controller.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2789   +/-   ##
=======================================
  Coverage   26.28%   26.29%           
=======================================
  Files        1707     1707           
  Lines       91478    91483    +5     
  Branches    19368    19369    +1     
=======================================
+ Hits        24046    24056   +10     
+ Misses      67432    67427    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jul 16, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@weird94 weird94 merged commit beb9146 into dev Jul 16, 2024
13 checks passed
@weird94 weird94 deleted the fix/move-cursor branch July 16, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants