Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheet): defined name panel style #2797

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Conversation

DR-Univer
Copy link
Collaborator

@DR-Univer DR-Univer commented Jul 17, 2024

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.09%. Comparing base (b72e2ce) to head (fb40e0c).
Report is 215 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2797      +/-   ##
==========================================
- Coverage   26.20%   26.09%   -0.11%     
==========================================
  Files        1729     1742      +13     
  Lines       91896    92305     +409     
  Branches    19432    19496      +64     
==========================================
+ Hits        24080    24088       +8     
- Misses      67816    68217     +401     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jul 17, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev merged commit 23a581b into dev Aug 19, 2024
13 checks passed
@wzhudev wzhudev deleted the fix-defined-name-panel-style branch August 19, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants