Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecated float-dom.props #2864

Merged
merged 3 commits into from
Jul 27, 2024
Merged

feat: deprecated float-dom.props #2864

merged 3 commits into from
Jul 27, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Jul 27, 2024

For saving to disk, props will be deprecated in future.

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@weird94 weird94 changed the title feat: float-dom-props fix: float-dom-props missing after tab change Jul 27, 2024
Copy link

codecov bot commented Jul 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 26.93%. Comparing base (db3c2f1) to head (98675b7).

Files Patch % Lines
...i/src/services/canvas-float-dom-manager.service.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2864   +/-   ##
=======================================
  Coverage   26.93%   26.93%           
=======================================
  Files        1791     1791           
  Lines       94425    94425           
  Branches    20156    20156           
=======================================
  Hits        25433    25433           
  Misses      68992    68992           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jul 27, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@weird94 weird94 changed the title fix: float-dom-props missing after tab change feat: deprecated float-dom.props Jul 27, 2024
@wzhudev wzhudev merged commit 43220a1 into dev Jul 27, 2024
11 checks passed
@wzhudev wzhudev deleted the fix/float-dom-props branch July 27, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants