Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(formula): add some engineering function #2893

Merged
merged 12 commits into from
Aug 13, 2024
Merged

Conversation

wpxp123456
Copy link
Contributor

@wpxp123456 wpxp123456 commented Jul 30, 2024

close #2872
close https://github.com/dream-num/univer-pro/issues/2049

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@wpxp123456 wpxp123456 added the qa:untested This PR is ready to be tested label Jul 30, 2024
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 70.30043% with 346 lines in your changes missing coverage. Please review.

Project coverage is 26.56%. Comparing base (e07e0c8) to head (752dc94).

Files Patch % Lines
packages/engine-formula/src/basics/engineering.ts 48.65% 134 Missing ⚠️
...formula/src/functions/engineering/convert/index.ts 24.52% 120 Missing ⚠️
...formula/src/functions/engineering/dec2bin/index.ts 80.00% 7 Missing ⚠️
...formula/src/functions/engineering/hex2bin/index.ts 81.08% 7 Missing ⚠️
...formula/src/functions/engineering/oct2bin/index.ts 81.08% 7 Missing ⚠️
...formula/src/functions/engineering/dec2hex/index.ts 82.35% 6 Missing ⚠️
...formula/src/functions/engineering/dec2oct/index.ts 82.35% 6 Missing ⚠️
...formula/src/functions/engineering/hex2oct/index.ts 82.85% 6 Missing ⚠️
...formula/src/functions/engineering/bin2hex/index.ts 84.37% 5 Missing ⚠️
...formula/src/functions/engineering/bin2oct/index.ts 84.37% 5 Missing ⚠️
... and 19 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2893      +/-   ##
==========================================
+ Coverage   26.01%   26.56%   +0.54%     
==========================================
  Files        1918     1948      +30     
  Lines      102169   103327    +1158     
  Branches    21794    22155     +361     
==========================================
+ Hits        26580    27449     +869     
- Misses      75589    75878     +289     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jul 30, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@wpxp123456 wpxp123456 force-pushed the feat/add-engineering-func branch 2 times, most recently from 86e7663 to 7bde977 Compare August 12, 2024 06:43
@wpxp123456 wpxp123456 force-pushed the feat/add-engineering-func branch from fb0574f to 752dc94 Compare August 13, 2024 02:44
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Aug 13, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Aug 13, 2024
@wpxp123456 wpxp123456 merged commit 9386c6b into dev Aug 13, 2024
9 checks passed
@wpxp123456 wpxp123456 deleted the feat/add-engineering-func branch August 13, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] More Engineering Formulas
3 participants