Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formula): fix formula parameter assignment #2905

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

wpxp123456
Copy link
Contributor

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@wpxp123456 wpxp123456 requested a review from jikkai August 1, 2024 08:34
@wpxp123456 wpxp123456 requested a review from DR-Univer as a code owner August 1, 2024 08:34
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 85.42814% with 291 lines in your changes missing coverage. Please review.

Project coverage is 27.55%. Comparing base (28ccb6f) to head (bf2139b).

Files Patch % Lines
...ngine-formula/src/functions/date/yearfrac/index.ts 61.32% 41 Missing ⚠️
...ngine-formula/src/functions/lookup/filter/index.ts 35.93% 41 Missing ⚠️
...ngine-formula/src/functions/lookup/sortby/index.ts 76.56% 30 Missing ⚠️
.../engine-formula/src/functions/lookup/sort/index.ts 83.83% 16 Missing ⚠️
...rmula/src/functions/date/networkdays-intl/index.ts 77.35% 12 Missing ⚠️
...e-formula/src/functions/date/workday-intl/index.ts 81.66% 11 Missing ⚠️
...engine-formula/src/functions/date/workday/index.ts 78.00% 11 Missing ⚠️
...gine-formula/src/functions/text/textsplit/index.ts 86.74% 11 Missing ⚠️
...ne-formula/src/functions/date/networkdays/index.ts 78.26% 10 Missing ⚠️
...gine-formula/src/functions/math/randarray/index.ts 84.84% 10 Missing ⚠️
... and 36 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2905      +/-   ##
==========================================
+ Coverage   27.44%   27.55%   +0.11%     
==========================================
  Files        1821     1821              
  Lines       95867    95939      +72     
  Branches    20612    20524      -88     
==========================================
+ Hits        26306    26435     +129     
+ Misses      69561    69504      -57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wpxp123456 wpxp123456 force-pushed the fix/formula-parameter-assignment branch from 8a9ee45 to bf2139b Compare August 1, 2024 08:43
Copy link

github-actions bot commented Aug 1, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@wpxp123456 wpxp123456 requested a review from wzhudev August 1, 2024 08:59
@wpxp123456 wpxp123456 merged commit 8fb9655 into dev Aug 2, 2024
9 checks passed
@wpxp123456 wpxp123456 deleted the fix/formula-parameter-assignment branch August 2, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants