Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unitId type error in handle editor invisible #2907

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Conversation

lumixraku
Copy link
Contributor

@lumixraku lumixraku commented Aug 2, 2024

close #2906

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@lumixraku lumixraku requested a review from Jocs as a code owner August 2, 2024 03:31
@lumixraku lumixraku requested a review from jikkai August 2, 2024 03:31
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.55%. Comparing base (28ccb6f) to head (db112a6).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2907      +/-   ##
==========================================
+ Coverage   27.44%   27.55%   +0.11%     
==========================================
  Files        1821     1821              
  Lines       95867    95939      +72     
  Branches    20612    20524      -88     
==========================================
+ Hits        26306    26435     +129     
+ Misses      69561    69504      -57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Aug 2, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Aug 2, 2024
@jikkai jikkai removed the qa:untested This PR is ready to be tested label Aug 2, 2024
@jikkai jikkai merged commit 5e09017 into dev Aug 2, 2024
10 checks passed
@jikkai jikkai deleted the fix/editor-type branch August 2, 2024 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants