Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(conditional-formatting): can not add custom formula #2915

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

Gggpound
Copy link
Contributor

@Gggpound Gggpound commented Aug 3, 2024

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Aug 3, 2024
Copy link

github-actions bot commented Aug 3, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Aug 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 27.48%. Comparing base (3c88b77) to head (8fa5e2d).
Report is 12 commits behind head on dev.

Files Patch % Lines
...ting-ui/src/components/panel/rule-edit/formula.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2915      +/-   ##
==========================================
- Coverage   27.48%   27.48%   -0.01%     
==========================================
  Files        1827     1827              
  Lines       96163    96164       +1     
  Branches    20561    20561              
==========================================
  Hits        26434    26434              
- Misses      69729    69730       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Aug 6, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Aug 6, 2024
@Gggpound Gggpound merged commit e9435ee into dev Aug 6, 2024
10 checks passed
@Gggpound Gggpound deleted the fix-conditional-formatting-0803 branch August 6, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Conditional formatting custom formula cannot be saved
3 participants