Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: slide editor disappear when moving curor by keyboard (arrow key) #2972

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

lumixraku
Copy link
Contributor

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@lumixraku lumixraku changed the title fix: addtext slide fix: slide editor disappear when moving curor by keyboard (arrow key) Aug 8, 2024
@lumixraku lumixraku marked this pull request as ready for review August 8, 2024 03:40
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 26.12%. Comparing base (04accd2) to head (8a81255).

Files Patch % Lines
...src/controllers/slide-editing.render-controller.ts 0.00% 8 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2972   +/-   ##
=======================================
  Coverage   26.11%   26.12%           
=======================================
  Files        1906     1906           
  Lines      101635   101638    +3     
  Branches    21683    21685    +2     
=======================================
+ Hits        26544    26550    +6     
+ Misses      75091    75088    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Aug 8, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@lumixraku lumixraku merged commit 448dcb1 into dev Aug 8, 2024
10 checks passed
@lumixraku lumixraku deleted the feat/addtext-slide branch August 8, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants