Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: slide toolbar&sidebar in uni-mode #2984

Merged
merged 4 commits into from
Aug 8, 2024
Merged

Conversation

yuhongz
Copy link
Contributor

@yuhongz yuhongz commented Aug 8, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@yuhongz yuhongz requested a review from jikkai as a code owner August 8, 2024 10:10
@yuhongz yuhongz requested a review from wzhudev August 8, 2024 10:10
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 31 lines in your changes missing coverage. Please review.

Project coverage is 26.11%. Comparing base (184ffdd) to head (07bfb16).

Files Patch % Lines
...ackages-experimental/uniui/src/controllers/menu.ts 0.00% 12 Missing ⚠️
...mental/uni-slides-ui/src/views/UniSlideSideBar.tsx 0.00% 10 Missing ⚠️
...es-ui/src/controllers/uni-slides-ui.controller.tsx 0.00% 6 Missing ⚠️
...ental/uniui/src/views/uni-controls/UniControls.tsx 0.00% 1 Missing ⚠️
packages/slides-ui/src/controllers/image.menu.ts 0.00% 1 Missing ⚠️
packages/slides-ui/src/controllers/shape.menu.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2984      +/-   ##
==========================================
- Coverage   26.12%   26.11%   -0.02%     
==========================================
  Files        1906     1906              
  Lines      101663   101688      +25     
  Branches    21695    21698       +3     
==========================================
- Hits        26563    26557       -6     
- Misses      75100    75131      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Aug 8, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@wzhudev wzhudev merged commit 3b72764 into dev Aug 8, 2024
9 checks passed
@wzhudev wzhudev deleted the yuhongz/add-slide-to-uni branch August 8, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants