Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set min-zoom to 0.1 #3001

Merged
merged 1 commit into from
Aug 9, 2024
Merged

feat: set min-zoom to 0.1 #3001

merged 1 commit into from
Aug 9, 2024

Conversation

yuhongz
Copy link
Contributor

@yuhongz yuhongz commented Aug 9, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 26.11%. Comparing base (8017323) to head (52ce589).

Files Patch % Lines
...ental/uniui/src/views/uni-controls/UniControls.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3001      +/-   ##
==========================================
- Coverage   26.11%   26.11%   -0.01%     
==========================================
  Files        1906     1906              
  Lines      101793   101793              
  Branches    21736    21736              
==========================================
- Hits        26585    26579       -6     
- Misses      75208    75214       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Aug 9, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@jikkai jikkai merged commit a90f948 into dev Aug 9, 2024
9 checks passed
@jikkai jikkai deleted the yuhongz/feat-uni-zoom branch August 9, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants