Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(slides): add text editing and shapes transform operations #3015

Merged
merged 5 commits into from
Aug 12, 2024

Conversation

jikkai
Copy link
Member

@jikkai jikkai commented Aug 10, 2024

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Aug 10, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Aug 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 50 lines in your changes missing coverage. Please review.

Project coverage is 26.04%. Comparing base (b6cc556) to head (73a1b2f).

Files Patch % Lines
.../src/commands/operations/insert-shape.operation.ts 0.00% 11 Missing ⚠️
...i/src/commands/operations/insert-text.operation.ts 0.00% 11 Missing ⚠️
...slides-ui/src/controllers/popup-menu.controller.ts 0.00% 8 Missing ⚠️
...ntrollers/slide-editor-bridge.render-controller.ts 0.00% 7 Missing ⚠️
.../src/commands/operations/insert-image.operation.ts 0.00% 5 Missing ⚠️
...-ui/src/components/upload-component/UploadFile.tsx 0.00% 3 Missing ⚠️
...mental/uni-slides-ui/src/views/UniSlideSideBar.tsx 0.00% 2 Missing ⚠️
...es/slides-ui/src/components/slide-bar/SlideBar.tsx 0.00% 2 Missing ⚠️
.../src/commands/operations/append-slide.operation.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3015      +/-   ##
==========================================
- Coverage   26.05%   26.04%   -0.01%     
==========================================
  Files        1915     1915              
  Lines      102034   102066      +32     
  Branches    21782    21788       +6     
==========================================
  Hits        26580    26580              
- Misses      75454    75486      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yuhongz yuhongz merged commit 3284b38 into dev Aug 12, 2024
9 checks passed
@yuhongz yuhongz deleted the feat/slide-operation branch August 12, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants