feat(formula): add some engineering functions #3070

wpxp123456 · 2024-08-15T07:45:47Z

Pull Request Checklist

Related tickets or issues have been linked in the PR description (or missing issue).
Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
Unit tests have been added for the changes (if applicable).
Breaking changes have been documented (or no breaking changes introduced in this PR).

codecov · 2024-08-15T07:52:44Z

Codecov Report

Attention: Patch coverage is 98.49946% with 14 lines in your changes missing coverage. Please review.

Files	Patch %	Lines
...ormula/src/engine/value-object/primitive-object.ts	82.60%	8 Missing ⚠️
packages/engine-formula/src/basics/complex.ts	98.26%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #3070      +/-   ##
==========================================
+ Coverage   27.62%   28.52%   +0.90%     
==========================================
  Files        1995     2022      +27     
  Lines      105869   106763     +894     
  Branches    22837    23057     +220     
==========================================
+ Hits        29242    30453    +1211     
+ Misses      76627    76310     -317

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-08-15T08:09:27Z

View Deployment

📑 Examples	📚 Storybook
🔗 Preview link	🔗 Preview link

wzhudev · 2024-08-16T12:09:50Z

packages/engine-formula/src/basics/engineering.ts

@@ -422,3 +428,416 @@ export function erf(x: number): number {

    return isneg ? res - 1 : 1 - res;
 };
+
+export class Complex {


This class deserve a complex.ts file of its own.

wzhudev · 2024-08-16T12:13:49Z

packages/engine-formula/package.json

@@ -65,6 +65,8 @@
        "rxjs": ">=7.0.0"
    },
    "dependencies": {
+        "big.js": "^6.2.1",


Please remove this if is not in your codes.

oumomomo · 2024-08-20T08:46:32Z

IMARGUMENT函数
单元格内输入=IMARGUMENT(H18+“1”)，删除H18行，错误码不对

univer-bot · 2024-08-20T08:46:37Z

IMARGUMENT function
Enter =IMARGUMENT(H18+"1") in the cell and delete row H18. The error code is incorrect.

oumomomo · 2024-08-21T03:50:33Z

imexp函数
输入=IMEXP("")，计算结果不一致

univer-bot · 2024-08-21T03:50:37Z

imexp function
Enter =IMEXP(""), the calculation results are inconsistent

oumomomo · 2024-08-21T06:49:44Z

IMLOG2函数

1、
单元格内输入=IMLOG2(-1)/=IMLOG2(0-1)，计算结果不对

2、
单元格输入=IMLOG2(-11111111111)/=IMLOG2(-1+-3)，计算结果少了

univer-bot · 2024-08-21T06:49:49Z

IMLOG2 function

Enter =IMLOG2(-1)/=IMLOG2(0-1) in the cell, and the calculation result is incorrect.

Cell input =IMLOG2(-11111111111)/=IMLOG2(-1+-3), the calculation result is less

oumomomo · 2024-08-21T07:47:04Z

IMPOWER函数

1、
单元格内输入=IMPOWER("2+3i", 895)/=IMPOWER("2+3i","25i")，错误码展示成了文本

univer-bot · 2024-08-21T07:47:09Z

IMPOWER function

Enter =IMPOWER("2+3i", 895)/=IMPOWER("2+3i", "25i") in the cell, and the error code will be displayed as text

oumomomo · 2024-08-21T09:30:29Z

IMPRODUCT函数
1、
单元格内输入=IMPRODUCT("0+1i")，计算结果错误

2、
单元格内输入=IMPRODUCT("1i+0.25")/=IMPRODUCT("99999988888i-9856")，excel展示为错误码

3、
单元格内输入=IMPRODUCT("")展示为空，excel展示为错误码

4、
单元格内输入=IMPRODUCT("1-12i","0.5-12j")，结果展示错误

5、
单元格内输入=IMPRODUCT("9i-测试哦 ")，结果展示错误

univer-bot · 2024-08-21T09:30:33Z

IMPRODUCT function
1.
Enter =IMPRODUCT("0+1i") in the cell, the calculation result is wrong

Enter =IMPRODUCT("1i+0.25")/=IMPRODUCT("99999988888i-9856") in the cell, and excel will display it as an error code

The input =IMPRODUCT("") in the cell is displayed as empty, and excel displays an error code.

Enter =IMPRODUCT("1-12i","0.5-12j") in the cell, and the result displays an error

Enter =IMPRODUCT("9i-Test ") in the cell, and the result displays an error

oumomomo · 2024-08-21T11:47:08Z

IMSEC函数
单元格内输入=IMSEC("")/=IMSECH("")/=IMSINH("")，计算结果有误

univer-bot · 2024-08-21T11:47:12Z

IMSEC function
Enter =IMSEC("")/=IMSECH("")/=IMSINH("") in the cell, and the calculation result is incorrect.

oumomomo · 2024-08-21T12:48:00Z

IMSINH函数
1、
输入=IMSINH(D1-D2)，D1=25698432，D2=-1，计算结果展示为空，且修改单元格内容计算结果不会更新

2、
输入=IMSECH(A1-"0.1")，A1=325，计算结果展示错误

3、
输入=IMSINH("0.00000002")，计算结果展示错误

univer-bot · 2024-08-21T12:48:04Z

IMSINH function
1.
Input =IMSINH(D1-D2), D1=25698432, D2=-1, the calculation result is displayed as empty, and the calculation result will not be updated if the cell content is modified.

Input=IMSECH(A1-"0.1"), A1=325, the calculation result displays an error

Input =IMSINH("0.00000002"), the calculation result displays an error

oumomomo · 2024-08-23T02:55:31Z

该评论以下的问题均未修复

univer-bot · 2024-08-23T02:55:37Z

None of the issues below this comment have been fixed

oumomomo · 2024-08-23T03:35:05Z

IMSQRT函数
1、
单元格输入=IMSQRT("-i")，计算结果展示为了+号

2、
单元格内输入=IMSQRT("-0.023")/=IMSQRT("-0.4")/=IMSQRT("-1")，计算结果不对

3、
单元格内输入=IMSQRT("9.2568"-C13)，C13=1 计算结果不对

4、
单元格内输入=IMSQRT(C19-C20)，C19为空，C20=1 计算结果不对

5、
单元格内输入=IMSQRT(G33-G34)，G33=-1，G34=2，计算结果不对

univer-bot · 2024-08-23T03:35:11Z

IMSQRT function
1.
Cell input =IMSQRT("-i"), the calculation result is displayed as a + sign

Enter =IMSQRT("-0.023")/=IMSQRT("-0.4")/=IMSQRT("-1") in the cell, and the calculation result is incorrect.

Enter =IMSQRT("9.2568"-C13) in the cell, C13=1, the calculation result is incorrect

Enter =IMSQRT(C19-C20) in the cell, C19 is empty, C20=1, the calculation result is incorrect

Enter =IMSQRT(G33-G34), G33=-1, G34=2 in the cell, and the calculation result is incorrect.

oumomomo · 2024-08-23T11:35:24Z

IMSUM函数

1、单元格内输入=IMSUM("3+4i","5-3i")1，预期应该报错

univer-bot · 2024-08-23T11:35:29Z

IMSUM function

Enter =IMSUM("3+4i","5-3i")1 in the cell. It is expected that an error will be reported.

oumomomo · 2024-08-23T12:37:15Z

IMTAN函数

1、在单元格内输入=IMTAN(E19+E20:E21)，计算不出结果

univer-bot · 2024-08-23T12:37:19Z

IMTAN function

Enter =IMTAN(E19+E20:E21) in the cell, but the result cannot be calculated.

wzhudev

LGTM

wpxp123456 added the qa:untested This PR is ready to be tested label Aug 15, 2024

wpxp123456 requested review from DR-Univer and Dushusir as code owners August 15, 2024 07:45

DR-Univer approved these changes Aug 15, 2024

View reviewed changes

wzhudev requested changes Aug 16, 2024

View reviewed changes

wpxp123456 force-pushed the feat/add-engineering-func branch 4 times, most recently from f5aea86 to 5916fd9 Compare August 22, 2024 12:54

oumomomo added qa:rejected and removed qa:untested This PR is ready to be tested labels Aug 24, 2024

wpxp123456 added 7 commits August 24, 2024 14:16

feat(formula): add some engineering functions

ad868e5

fix(formula): del big.js

0cb1099

fix(formula): fix lint

c52ed43

fix(formula): fix bugs

25adf1b

fix(formula): fix bug

1a97232

fix(formula): fix codecov

38286bb

fix(formula): fix bug

0dc3c67

wpxp123456 force-pushed the feat/add-engineering-func branch from 0487bae to 0dc3c67 Compare August 24, 2024 06:17

oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Aug 24, 2024

univer-bot bot removed the qa:rejected label Aug 24, 2024

wpxp123456 requested a review from wzhudev August 24, 2024 06:56

fix(formula): split complex.ts

841cbbb

wzhudev approved these changes Aug 24, 2024

View reviewed changes

wpxp123456 merged commit dbe1dab into dev Aug 24, 2024
9 checks passed

wpxp123456 deleted the feat/add-engineering-func branch August 24, 2024 07:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(formula): add some engineering functions #3070

feat(formula): add some engineering functions #3070

wpxp123456 commented Aug 15, 2024

codecov bot commented Aug 15, 2024 •

edited

Loading

github-actions bot commented Aug 15, 2024 •

edited

Loading

wzhudev Aug 16, 2024

wzhudev Aug 16, 2024

wpxp123456 Aug 21, 2024

oumomomo commented Aug 20, 2024

univer-bot bot commented Aug 20, 2024

oumomomo commented Aug 21, 2024

univer-bot bot commented Aug 21, 2024

oumomomo commented Aug 21, 2024 •

edited

Loading

univer-bot bot commented Aug 21, 2024 •

edited

Loading

oumomomo commented Aug 21, 2024 •

edited

Loading

univer-bot bot commented Aug 21, 2024 •

edited

Loading

oumomomo commented Aug 21, 2024 •

edited

Loading

univer-bot bot commented Aug 21, 2024 •

edited

Loading

oumomomo commented Aug 21, 2024 •

edited

Loading

univer-bot bot commented Aug 21, 2024 •

edited

Loading

oumomomo commented Aug 21, 2024 •

edited

Loading

univer-bot bot commented Aug 21, 2024 •

edited

Loading

oumomomo commented Aug 23, 2024 •

edited

Loading

univer-bot bot commented Aug 23, 2024 •

edited

Loading

oumomomo commented Aug 23, 2024 •

edited

Loading

univer-bot bot commented Aug 23, 2024 •

edited

Loading

oumomomo commented Aug 23, 2024

univer-bot bot commented Aug 23, 2024

oumomomo commented Aug 23, 2024

univer-bot bot commented Aug 23, 2024

wzhudev left a comment

feat(formula): add some engineering functions #3070

feat(formula): add some engineering functions #3070

Conversation

wpxp123456 commented Aug 15, 2024

Pull Request Checklist

codecov bot commented Aug 15, 2024 • edited Loading

Codecov Report

github-actions bot commented Aug 15, 2024 • edited Loading

View Deployment

wzhudev Aug 16, 2024

Choose a reason for hiding this comment

wzhudev Aug 16, 2024

Choose a reason for hiding this comment

wpxp123456 Aug 21, 2024

Choose a reason for hiding this comment

oumomomo commented Aug 20, 2024

univer-bot bot commented Aug 20, 2024

oumomomo commented Aug 21, 2024

univer-bot bot commented Aug 21, 2024

oumomomo commented Aug 21, 2024 • edited Loading

univer-bot bot commented Aug 21, 2024 • edited Loading

oumomomo commented Aug 21, 2024 • edited Loading

univer-bot bot commented Aug 21, 2024 • edited Loading

oumomomo commented Aug 21, 2024 • edited Loading

univer-bot bot commented Aug 21, 2024 • edited Loading

oumomomo commented Aug 21, 2024 • edited Loading

univer-bot bot commented Aug 21, 2024 • edited Loading

oumomomo commented Aug 21, 2024 • edited Loading

univer-bot bot commented Aug 21, 2024 • edited Loading

oumomomo commented Aug 23, 2024 • edited Loading

univer-bot bot commented Aug 23, 2024 • edited Loading

oumomomo commented Aug 23, 2024 • edited Loading

univer-bot bot commented Aug 23, 2024 • edited Loading

oumomomo commented Aug 23, 2024

univer-bot bot commented Aug 23, 2024

oumomomo commented Aug 23, 2024

univer-bot bot commented Aug 23, 2024

wzhudev left a comment

Choose a reason for hiding this comment

codecov bot commented Aug 15, 2024 •

edited

Loading

github-actions bot commented Aug 15, 2024 •

edited

Loading

oumomomo commented Aug 21, 2024 •

edited

Loading

univer-bot bot commented Aug 21, 2024 •

edited

Loading

oumomomo commented Aug 21, 2024 •

edited

Loading

univer-bot bot commented Aug 21, 2024 •

edited

Loading

oumomomo commented Aug 21, 2024 •

edited

Loading

univer-bot bot commented Aug 21, 2024 •

edited

Loading

oumomomo commented Aug 21, 2024 •

edited

Loading

univer-bot bot commented Aug 21, 2024 •

edited

Loading

oumomomo commented Aug 21, 2024 •

edited

Loading

univer-bot bot commented Aug 21, 2024 •

edited

Loading

oumomomo commented Aug 23, 2024 •

edited

Loading

univer-bot bot commented Aug 23, 2024 •

edited

Loading

oumomomo commented Aug 23, 2024 •

edited

Loading

univer-bot bot commented Aug 23, 2024 •

edited

Loading