Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): support modifying the toolbar items through setMenuItem #3083

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

jikkai
Copy link
Member

@jikkai jikkai commented Aug 15, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@jikkai jikkai requested a review from Jocs as a code owner August 15, 2024 10:15
@jikkai jikkai force-pushed the feat/modify-toolbar branch from a489ab0 to e5c062d Compare August 15, 2024 10:20
@jikkai jikkai force-pushed the feat/modify-toolbar branch from e5c062d to e9d790e Compare August 15, 2024 10:21
Copy link

github-actions bot commented Aug 15, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 27.48%. Comparing base (bf697b6) to head (e9d790e).
Report is 1 commits behind head on dev.

Files Patch % Lines
packages/ui/src/services/menu/menu.service.ts 0.00% 13 Missing ⚠️
...uni-formula-ui/src/services/uni-formula.service.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3083      +/-   ##
==========================================
- Coverage   27.48%   27.48%   -0.01%     
==========================================
  Files        1980     1980              
  Lines      104706   104719      +13     
  Branches    22596    22601       +5     
==========================================
  Hits        28782    28782              
- Misses      75924    75937      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jikkai jikkai merged commit ff51551 into dev Aug 15, 2024
9 checks passed
@jikkai jikkai deleted the feat/modify-toolbar branch August 15, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant