Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hyper-link ref-range error on filter #3135

Merged
merged 5 commits into from
Aug 22, 2024
Merged

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Aug 20, 2024

close https://github.com/dream-num/univer-pro/issues/2152

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Aug 20, 2024
Copy link

github-actions bot commented Aug 20, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 27.63%. Comparing base (2544c8f) to head (f36b8e2).
Report is 14 commits behind head on dev.

Files Patch % Lines
packages/sheets/src/services/ref-range/util.ts 60.00% 8 Missing ⚠️
...hyper-link/src/controllers/ref-range.controller.ts 0.00% 2 Missing ⚠️
...lers/sheets-thread-comment-ref-range.controller.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3135      +/-   ##
==========================================
+ Coverage   27.48%   27.63%   +0.14%     
==========================================
  Files        1980     1985       +5     
  Lines      104962   105572     +610     
  Branches    22652    22793     +141     
==========================================
+ Hits        28854    29171     +317     
- Misses      76108    76401     +293     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need unit tests for this change as it is widely used.

@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Aug 21, 2024
@oumomomo
Copy link

还是可以复现
image

@univer-bot
Copy link

univer-bot bot commented Aug 21, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

It can still be reproduced
image

@weird94 weird94 requested a review from jikkai as a code owner August 22, 2024 07:51
@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Aug 22, 2024
@univer-bot univer-bot bot removed the qa:rejected label Aug 22, 2024
@weird94 weird94 merged commit 014dd67 into dev Aug 22, 2024
9 checks passed
@weird94 weird94 deleted the feat/ref-range-filter branch August 22, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants