Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheets-drawing): drawing snapshot error #3230

Merged
merged 3 commits into from
Aug 30, 2024
Merged

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Aug 28, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Aug 28, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@weird94 weird94 added the qa:untested This PR is ready to be tested label Aug 28, 2024
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 28.57%. Comparing base (84e8c89) to head (396a4c8).
Report is 15 commits behind head on dev.

Files with missing lines Patch % Lines
...der-controllers/sheet-drawing.render-controller.ts 0.00% 2 Missing ⚠️
...rawing/src/controllers/sheet-drawing.controller.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3230      +/-   ##
==========================================
- Coverage   28.62%   28.57%   -0.06%     
==========================================
  Files        2025     2022       -3     
  Lines      106979   106758     -221     
  Branches    23134    23100      -34     
==========================================
- Hits        30623    30503     -120     
+ Misses      76356    76255     -101     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Aug 28, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Aug 28, 2024
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weird94 weird94 merged commit f5f52bf into dev Aug 30, 2024
9 checks passed
@weird94 weird94 deleted the fix/drawing-snapshot branch August 30, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants